Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples to plugin docs #97

Merged
merged 3 commits into from
Nov 17, 2022

Conversation

AfiMaameDufie
Copy link
Contributor

Add Examples to Plugin Docs

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • I added examples of the input plugin with parameters.

@AfiMaameDufie
Copy link
Contributor Author

@MarkEWaite Can you kindly take a look at this?

Copy link

@kmartens27 kmartens27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything looks great! updated the text to be more inline with writing standards, but all the content is wonderful!

README.md Outdated Show resolved Hide resolved
@AfiMaameDufie
Copy link
Contributor Author

@kmartens27 Hi Kevin, can you kindly review the change?

Copy link

@kmartens27 kmartens27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything looks great!!

@kmartens27
Copy link

Just reviewed @AfiMaameDufie everything looks awesome, thanks so much!

@rsandell rsandell merged commit 0288444 into jenkinsci:master Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants