Added new when conditions stashed and archived #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When condition for checking if something is stashed by earlier stages
Also fixed a directive generator bug in both stashed and archived when the advanced section got expanded the comparator got filled in.
|
Tickling the PR builder. |
They use the sh step to produce files
|
@bitwiseman ping? |
|
@rsandell Sorry, distracted by other work. Looks like this still needs to pass CI. Trying again. |
bitwiseman
approved these changes
Nov 4, 2019
There was a problem hiding this comment.
@rsandell Looks good to me. Still need to do the documentation, right?
|
Docs, right :) |
|
@rsandell Do you have time to do docs for this, or would you like me to pick this up? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was originally planning to add these to the
declarative-pipeline-when-conditions-pluginsince these conditions might be a bit niche. But after an hour of fixing "require upper bounds" issues in the pom I found out that the API for allowing other plugins to contribute when conditions wasn't "fixed" yet.