Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove lib.form.hetero-list.hetero-list #680

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

car-roll
Copy link
Contributor

@car-roll car-roll commented Nov 7, 2023

See jenkinsci/jenkins#8418 (comment)

hetero-list adjunct was removed in jenkinsci/jenkins#8418
If this adjunct gets called, a large stack trace error should appear in the logs.

Testing

Done locally, but I was not able to identify the gui interface for the ToolsDirective that would exercise the adjunct.

@car-roll car-roll requested a review from a team November 7, 2023 02:07
@car-roll car-roll added the chore label Nov 7, 2023
@@ -133,7 +133,7 @@
<properties>
<changelist>999999-SNAPSHOT</changelist>
<gitHubRepo>jenkinsci/pipeline-model-definition-plugin</gitHubRepo>
<jenkins.version>2.387.3</jenkins.version>
<jenkins.version>2.426</jenkins.version>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change was introduced in 2.422, chose the (soon-to-be) next LTS

@car-roll car-roll added bug and removed chore labels Nov 8, 2023
@car-roll car-roll merged commit e32c9d2 into jenkinsci:master Nov 8, 2023
15 checks passed
@car-roll car-roll deleted the remove-adjunct branch November 8, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants