Optional plugins missing from update center should not fail installation #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When resolving plugin, we will eagerly check the update center for plugin metadata, even when that plugin is optional. When the plugin is missing from update center, we end up failing the installation. This doe snot make sense for optional plugins. These plugins are likely never going to be installed, so it isn't a big deal that we are missing some metadata. Instead of failing the build, we just print a warning. If another plugin does depend on this missing plugin in a non-optional way, we will fail the installation at that point.
timja
reviewed
Mar 2, 2021
plugin-management-library/src/main/java/io/jenkins/tools/pluginmanager/impl/PluginManager.java
Outdated
Show resolved
Hide resolved
timja
reviewed
Mar 2, 2021
plugin-management-library/src/main/java/io/jenkins/tools/pluginmanager/impl/PluginManager.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
|
@timja I think this build error is a transient error. How can I retrigger? |
You can close your PR wait a few seconds and open it is the easiest if you don't have write access, I've re-triggered for you though |
|
it failed a few times, i've deleted that agent =/ |
timja
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When resolving plugin, we will eagerly check the update center
for plugin metadata, even when that plugin is optional. When the
plugin is missing from update center, we end up failing the
installation.
This does not make sense for optional plugins. These plugins are
likely never going to be installed, so it isn't a problem that
we are missing some metadata. Instead of failing the build, we
just print a warning.
If another plugin does depend on this missing plugin in a
non-optional way, we will fail the installation at that point.
Fixes #294