-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show security warnings by default (#258) #522
Conversation
Thanks for the pull request! The "show all security warnings" is too verbose to be enabled by default. The original request from Daniel was to enable security warnings for the mentioned plugins, not for all plugins. I think that would be much better for the user. When I run it with the following test case it outputs the list of all plugins that have unresolved security issues, even though I mentioned only one of those plugins:
Could you undo the enablement (and deprecation) of the all security warnings setting? The rest of the change looks very good. |
…ngs is false, and --view-security-warnings is true by default (jenkinsci#258)
Thanks for your suggestion. I've edited it and pushed it again. For now, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed in Docs Office Hours with @freyam and @StackScribe. Tested and saw expected behavior in general cases.
Wondered during review if we should suppress the Security warnings
text if there are no warnings. However, this is a good change whether we suppress the warnings or not.
Fixes #258