Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for file:// protocol in plugin URI #365 #531

Closed
wants to merge 10 commits into from

Conversation

mukundsrinivasb
Copy link

Fixes #365

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

I have tried to list all the urls as a verbose message.
I am unable to run maven-build
This is the relevant issue.

@mukundsrinivasb
Copy link
Author

The Objective in this case is twofold :

  1. Why is the maven build command not working.
  2. Is this the right way to submit a Pull Request

@MarkEWaite
Copy link
Contributor

The Objective in this case is twofold :

  1. Why is the maven build command not working.

It fails because tests are failing. Failing tests mean that your changes caused something that the tests did not expect. In this case, one of the problems is that it is almost never a good idea to catch null pointer exceptions. If something can be null, it should be checked if it is null before it is referenced.

  1. Is this the right way to submit a Pull Request

Yes, this is the right way to submit a pull request, though it is usually preferred that before you submit a pull request you confirm locally that the tests pass. If you don't understand a test failure, it is OK to submit a failing test accompanied by a comment that notes the test is failing. That note should also clarify what you've tried while exploring the failing test.

@mukundsrinivasb
Copy link
Author

Thanks a lot , In the next PR, I shall make sure all the tests pass locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for file:// protocol in plugin URI
2 participants