-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generating plugins lock file #631
Conversation
} | ||
logVerbose("Plugin lock file (" + pluginLockFile + ") has been successfully created."); | ||
} catch (UnsupportedEncodingException e) { | ||
e.printStackTrace(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid e.printStackTrace()
by Logging Exception Output Instead
use logger.info("Unsupported encoding: ", e);
through import org.apache.log4j.Logger;
. Details can be read at CodeQL documentaion https://codeql.github.com/codeql-query-help/java/java-stack-trace-exposure/
} catch (UnsupportedEncodingException e) { | ||
e.printStackTrace(); | ||
} catch (IOException e) { | ||
e.printStackTrace(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same use logger.info("IOException occurred: ", e);
through import org.apache.log4j.Logger;
instead of e.printStackTrace();
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some suggestion for code improvement above
Co-authored-by: Tim Jacomb <timjacomb1@gmail.com>
fixes #488
plugins-lock.txt
file is the full list of plugins generated at a point in time with a specific Jenkins version and includes the plugins declared by the user and all the dependencies of those plugins.plugins-lock.txt
file describe all the plugins and versions that were read from the Jenkins update center at the time the command was executed.A
plugins-lock.txt
file is created on the same directory as theplugins.txt
, in which plugins were listed to be downloaded and the listed plugins as well their dependencies are written in the lock file.Submitter checklist