Generating plugins lock file #631
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| logVerbose("Plugin lock file (" + pluginLockFile + ") has been successfully created."); | ||
| } catch (UnsupportedEncodingException e) { | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
Avoid e.printStackTrace() by Logging Exception Output Instead
use logger.info("Unsupported encoding: ", e); through import org.apache.log4j.Logger; . Details can be read at CodeQL documentaion https://codeql.github.com/codeql-query-help/java/java-stack-trace-exposure/
| } catch (UnsupportedEncodingException e) { | ||
| e.printStackTrace(); | ||
| } catch (IOException e) { | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
Same use logger.info("IOException occurred: ", e); through import org.apache.log4j.Logger; instead of e.printStackTrace();
Co-authored-by: Tim Jacomb <timjacomb1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #488
plugins-lock.txtfile is the full list of plugins generated at a point in time with a specific Jenkins version and includes the plugins declared by the user and all the dependencies of those plugins.plugins-lock.txtfile describe all the plugins and versions that were read from the Jenkins update center at the time the command was executed.A
plugins-lock.txtfile is created on the same directory as theplugins.txt, in which plugins were listed to be downloaded and the listed plugins as well their dependencies are written in the lock file.Submitter checklist