Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicit snakeyaml dependency #683

Merged

Conversation

MarkEWaite
Copy link
Contributor

Remove explicit snakeyaml dependency

Rely on the transitive dependency from the Jackson dataformat library.

Commit 6239603 added the dependency in order to assure that we were including the most recent release of the snakeyaml jar file. The Jackson dataformat library version that we are using already depends on the most recent snakeyaml release, so we no longer need this explicit dependency.

Reverts 6239603

Testing done

Confirmed that automated tests pass

Confirmed that the snakeyaml included in the plugin installation manager jar file after this change is the same as the snakeyaml included in the most recent release.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Rely on the transitive dependency from the Jackson dataformat library.

Commit 6239603 added the dependency in
order to assure that we were including the most recent release of the
snakeyaml jar file.  The Jackson dataformat library version that we are
using already depends on the most recent snakeyaml release, so we no
longer need this explicit dependency.

Reverts 6239603
@MarkEWaite MarkEWaite added the chore Project maintenance label May 24, 2024
@MarkEWaite MarkEWaite merged commit 03f34a3 into jenkinsci:master May 24, 2024
15 checks passed
@MarkEWaite MarkEWaite deleted the remove-explict-snakeyaml-dependency branch May 24, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants