Skip to content

Commit

Permalink
Setting source and target are unnecessary when setting release (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
basil authored Apr 2, 2022
1 parent 240d139 commit 3ed41c5
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -953,9 +953,16 @@
<jdk>[9,)</jdk>
</activation>
<properties>
<!-- When compiling with a Java 9+ compiler, we always rely on "release" in favor of "source" and "target", even when compiling to Java 8 bytecode. -->
<maven.compiler.release>8</maven.compiler.release>
<maven.compiler.testRelease>8</maven.compiler.testRelease>
<!-- "release" serves the same purpose as Animal Sniffer. -->
<animal.sniffer.skip>true</animal.sniffer.skip>
<!-- While it does not hurt to have these set to the Java specification version, it is also not needed when "release" is in use. -->
<maven.compiler.source combine.self="override" />
<maven.compiler.target combine.self="override" />
<maven.compiler.testSource combine.self="override" />
<maven.compiler.testTarget combine.self="override" />
<!-- Work around openjdk/jdk11u-dev#919. TODO When we upgrade to OpenJDK 11.0.16, this should be deleted. -->
<maven.compiler.forceJavacCompilerUse>true</maven.compiler.forceJavacCompilerUse>
<!-- Filled in by maven-hpi-plugin from the MANIFEST.MF entry in jenkins.war, but we provide a default value for the benefit of IDEs. -->
Expand Down

0 comments on commit 3ed41c5

Please sign in to comment.