Java10 Hacking

[svanoort]

• Handle Java version strings like "9" and "10" due to change in the nomenclature from 1.8, etc
  • Note that this requires all things taking up new plugin POM to change their java.level, i.e. "8" -> "1.8"

TODO:

• org.codehaus.mojo.signature artifactid hardcoded, because it does NOT include a period, i.e. 1.8 -> 18

[KostyaSha]

typo?

[KostyaSha]

will guice/guava/sezpoz as usual break? :D

[svanoort]

will guice/guava/sezpoz as usual break? :D

Runs fine with Java 10 as of the latest builds AFAICT.

The problem is all the tooling and so forth.

[oleg-nenashev]

@jenkinsci/java10-support

[KostyaSha]

The problem is all the tooling and so forth.

Where is my popcorn! :)

[oleg-nenashev]

@svanoort maybe it makes sense to integrate with master (#114) and bump Animal Sniffer to 1.17

[svanoort]

@oleg-nenashev Done -- now to figure out how we deal with the org.codehaus.mojo.signature dependencies?

[oleg-nenashev]

I would propose a more universal approach.

• Introduce java.effective.level property which defaults to 1.${java.level}
• Introduce java.effective.level.test property which defaults to java.effective.level
• Introduce codehaus.mojo.signature.artifactId prioperty which defaults to java1${java.level}
• Use new properties in the subject code
• Introduce JDK10 and JDK11 profiles which activate on proper java.level values and override the variables

It would allow to deliver this change without breaking compatibility with existing Plugin POM and without hardcoding anything.

WDYT @svanoort ?

[svanoort]

@oleg-nenashev I agree those are better approaches -- I hadn't considered that approach, but it seems a lot better.

[daniel-beck]

Unclear comment

[batmat]

This is now conflicted, and I suspect superseded.

@svanoort I'm planning to close this in the next days if you don't object. And obviously, if you come after I closed it, feel free to reopen if you think this must still get in.

Thanks!

[batmat]

Closing as per my last comment.