[JENKINS-51658] add reincrementalify to completionGoals

[jetersen]

cc @jglick @oleg-nenashev

This could be applied to https://github.com/jenkinsci/pom as well 👍

Here we can see the completionGoals in use: jenkinsci/kotlin-v1-stdlib-jdk8-plugin@afc6746

[ndeloof]

will this extra goal be a no-op on plugins without increment extension ?

[jetersen]

Indeed that is the case @ndeloof
The activation on the profile should ensure that at least the .mvn/maven.config and revision property is set before activating. Would love to check for changelist too but my knowledge and/or maven it self is very limited in that regard. https://issues.apache.org/jira/browse/MNG-3328

      <activation>
        <property>
          <name>revision</name>
        </property>
        <file>
          <exists>${basedir}/.mvn/maven.config</exists>
        </file>
      </activation>

[jetersen]

Oh I can do one better 😃 I can just check for might-produce-incrementals property!

[oleg-nenashev]

might != will though

[jetersen]

No but if the profile is activate, it means when you release you still get the benefit of completion goals sadly maven is limited once again and you cannot chain profiles

[jetersen]

I can't really see a good way of activating this profile without assuming you are using incremental if you have .mvn/config because of limitiation on maven.

if we make reincrementalify check if revision and changelist properties are in the POM before changing the pom we could make it fault tolerant and not break anybody.

[jetersen]

Added jenkinsci/incrementals-tools#5 to avoid breaking developers POM if for some odd reason they have .mvn/config with no revision or changelist in their POM when they try to perform a release.

[jglick]

Too much work and unreliable. Just put this configuration in the might-produce-incrementals profile and it will be activated exactly when it is needed.

[jglick]

Yes something similar should go into jenkinsci/pom but beware that @kohsuke’s automated script for releasing jenkins already reincrementalify and commit and push, so it would probably break—we would need to coördinate with him to turn that off.

[jetersen]

Followed your advice @jglick 👍

[jglick]

JENKINS-51658 FTR

[jglick]

As noted in jenkinsci/pom#27 (review) this would better be done using mojo configuration.

[jetersen]

I'll do a follow up 😊