[JENKINS-55456] Upgrade PowerMock version to 2.0.0

[alecharp]

JENKINS-55456

Upgrade powermock Junit and Mockito libraries from 2.0.0-RC.4 to 2.0.0.

[Wadeck]

Release note: 2.0.0 <-> 2.0.0-RC.4

Note as "enhancement", they remove some deprecated code parts issue 839. That could potentially lead to some regressions.

[batmat]

Please file downstream PRs on some critical plugins to assess this using a timestamped SNAPSHOT, ideally plugins using powermock.
See #137 for an example on the Git-plugin.

From a cursory look, it would look like a passing PR on both git-plugin and blueocean-plugin repos would be enough to detect potential/immediate regressions as noted by Wadeck.

Thanks!

[jtnord]

it was a complete shock to me that this was even included - personally I feel neither mocito nor powermock should be in here and it is up to the individual plugins to use them if they desire.

for example if a new plugin includes a test project from a plugin built with older parent the dependency will automatically be shunted and is liable o break things.

/shrug

[alecharp]

It's in the dependencyManagement. So we don't force anyone to use them, just we put a recommended version, so plugins can add those dependencies in their pom.xml without a version.

Also, if any plugin wants a different version, they can put a version to use and this will be ignored.

[oleg-nenashev]

Yes, it was deliberate since we have got a lot of fun while testing with Java 11

[jtnord]

Also, if any plugin wants a different version, they can put a version to use and this will be ignored

for an individual plugin yes, but if another plugin depends on that plugin no, the dependency gets overridden

[batmat]

Ping @alecharp.
BTW if you need help on how to create such "downstream PRs", you know how to reach out to me :-).

Have a great weekend!

[alecharp]

@batmat I'm working on the PR for blueocean-plugin but the project already has a <dependencyManagement/> for PowerMock and Mockito. I'm not sure they will agree to remove them. I'm opening a PR anyway.

[oleg-nenashev]

🚢 🇮🇹 ?

[alecharp]

It seems that the PR in Git Plugin is building correctly. See jenkinsci/git-plugin#662. Maybe we could merge this.