-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-57425] Add profile to run benchmarks only when the benchmark
property is set
#206
[JENKINS-57425] Add profile to run benchmarks only when the benchmark
property is set
#206
Conversation
Another unreleated build failure 🤔:
|
https://issues.jenkins-ci.org/browse/INFRA-2062 an ongoing issue |
@Casz Thanks for the information! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me as code, but it would be also great to have documentation and maybe a short integration test in src/it
@oleg-nenashev Where do I add the integration test inside EDIT: Got the information from Maven Invoker Plugin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me. Maybe we should really run the benchmark once jenkinsci/jenkins-test-harness#135 is integrated.
Once the build in jenkinsci/jenkins-test-harness#135 completes successfully, there should be an incrementals release deployed.
Then you could just test it by including it into POM.
The integration test would require a patch to consume incrementals. https://github.com/jenkinsci/incrementals-tools#usage-in-plugin-poms . But maybe it is just better to wait for a release
The build fails because incrementals need to be enabled with
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me, and thanks for integration tests!
I am going to merge and release it to unblock further integration of changes by @AbhyudayaSharma . All the code is isolated by the profile (no default behavior change) and has integration tests, so it should be fine. @batmat @jglick I will address any follow-up requests if needed |
Adds a profile to run JMH benchmarks only when the
benchmark
property is set. Follow-up to jenkinsci/jenkins-test-harness#135 .@jenkinsci/gsoc2019-role-strategy