Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-57425] Add profile to run benchmarks only when the benchmark property is set #206

Merged
merged 5 commits into from
Jun 14, 2019

Conversation

AbhyudayaSharma
Copy link
Member

Adds a profile to run JMH benchmarks only when the benchmark property is set. Follow-up to jenkinsci/jenkins-test-harness#135 .

@jenkinsci/gsoc2019-role-strategy

@AbhyudayaSharma
Copy link
Member Author

Another unreleated build failure 🤔:

Failed to run image 'maven:3.6.0-jdk-8'. Error: docker: Error response from daemon: mkdir /var/lib/docker/overlay2/b5073d410ec3435d970b02bd8eca4768dca47542a46270394ec65a960b2ed6e0-init: no space left on device.

@jetersen
Copy link
Member

jetersen commented Jun 5, 2019

https://issues.jenkins-ci.org/browse/INFRA-2062 an ongoing issue

@AbhyudayaSharma
Copy link
Member Author

@Casz Thanks for the information!

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as code, but it would be also great to have documentation and maybe a short integration test in src/it

@AbhyudayaSharma
Copy link
Member Author

AbhyudayaSharma commented Jun 5, 2019

Looks good to me as code, but it would be also great to have documentation and maybe a short integration test in src/it

@oleg-nenashev Where do I add the integration test inside src/it? The existing folders are confusing. Do I use them or do I create a new folder for this?

EDIT: Got the information from Maven Invoker Plugin

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. Maybe we should really run the benchmark once jenkinsci/jenkins-test-harness#135 is integrated.

Once the build in jenkinsci/jenkins-test-harness#135 completes successfully, there should be an incrementals release deployed.

Then you could just test it by including it into POM.
The integration test would require a patch to consume incrementals. https://github.com/jenkinsci/incrementals-tools#usage-in-plugin-poms . But maybe it is just better to wait for a release

@AbhyudayaSharma
Copy link
Member Author

The build fails because incrementals need to be enabled with -Pconsume-incrementals:

[2019-06-11T05:01:49.141Z] [ERROR] Failed to execute goal on project plugin: Could not resolve dependencies for project org.jenkins-ci.plugins:plugin:pom:3.44-SNAPSHOT: Could not find artifact org.jenkins-ci.main:jenkins-test-harness:jar:2.50-rc1168.d591189fccf7 in repo.jenkins-ci.org (https://repo.jenkins-ci.org/public/) -> [Help 1]

@AbhyudayaSharma AbhyudayaSharma marked this pull request as ready for review June 14, 2019 03:55
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, and thanks for integration tests!

@oleg-nenashev
Copy link
Member

I am going to merge and release it to unblock further integration of changes by @AbhyudayaSharma . All the code is isolated by the profile (no default behavior change) and has integration tests, so it should be fine.

@batmat @jglick I will address any follow-up requests if needed

@oleg-nenashev oleg-nenashev merged commit c466595 into jenkinsci:master Jun 14, 2019
@AbhyudayaSharma AbhyudayaSharma deleted the benchmark-profile branch June 14, 2019 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants