Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude javax.servlet:servlet-api #469

Merged
merged 1 commit into from
Dec 16, 2021
Merged

Exclude javax.servlet:servlet-api #469

merged 1 commit into from
Dec 16, 2021

Conversation

basil
Copy link
Member

@basil basil commented Dec 16, 2021

Without this exclusion, recent versions of Maven Enforcer fail against recent cores with:

Require upper bound dependencies error for javax.servlet:servlet-api:0 [provided] paths to dependency are:
+-org.jenkins-ci.plugins:gitlab-plugin:1.5.25-SNAPSHOT
  +-org.jenkins-ci.main:jenkins-core:2.326-SNAPSHOT [provided]
    +-javax.servlet:servlet-api:0 [provided] (managed) <-- javax.servlet:servlet-api:[0] [provided]
and
+-org.jenkins-ci.plugins:gitlab-plugin:1.5.25-SNAPSHOT
  +-org.jenkins-ci.main:jenkins-war:2.326-SNAPSHOT [test]
    +-javax.servlet:servlet-api:0 [provided] (managed) <-- javax.servlet:servlet-api:[0] [provided]
and
+-org.jenkins-ci.plugins:gitlab-plugin:1.5.25-SNAPSHOT
  +-org.jenkins-ci.main:jenkins-core:2.326-SNAPSHOT [provided]
    +-org.jenkins-ci.main:cli:2.326-SNAPSHOT [provided]
      +-javax.servlet:servlet-api:0 [provided] (managed) <-- javax.servlet:servlet-api:[0] [provided]

@basil basil added the dependencies Pull requests that update a dependency file label Dec 16, 2021
@basil basil merged commit ddca5db into jenkinsci:master Dec 16, 2021
@basil basil deleted the servlet-api branch December 16, 2021 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timja timja timja approved these changes

@jetersen jetersen jetersen approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@basil @jetersen @timja