Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align frontend-version with frontend-m-p prerequisite of 3.1.0 #53

Merged
merged 1 commit into from
Apr 4, 2017

Conversation

batmat
Copy link
Member

@batmat batmat commented Mar 28, 2017

1.3 was already having a prerequisite on Maven 3.1.0.

So, updating pom.xml to reflect and bumped the plugin to latest version.

@reviewbybees esp. @tfennelly @scherler @kzantow @michaelneale

@ghost
Copy link

ghost commented Mar 28, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@batmat batmat mentioned this pull request Mar 28, 2017
@michaelneale
Copy link
Member

no linked ticket? what is this about?

@batmat
Copy link
Member Author

batmat commented Mar 29, 2017

@michaelneale this update is not bug driven, hence why no JIRA filed. More a general plugin bump. I initially had this in #54 and finally decided on separating the frontend-m-p and prerequisite part for mainly a review by the BO team, as this is probably the main and only place this plugin is used.

I can file an issue if it's deemed necessary, though.

@michaelneale
Copy link
Member

ah ok - not sure I have much to add, doesn't seem to be a bad idea. @tfennelly may have some thoughts though. Most people use a much newer version of maven anyway if I read it correctly.

Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine AFAIK. @stephenc would probably know why 3.0.4 was chosen as a baseline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants