Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove --mutex network argument for Yarn builds #625

Merged
merged 11 commits into from
Nov 7, 2022
Merged

Remove --mutex network argument for Yarn builds #625

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8866e7b
[yarn2] add profile for yarn 2 which do not support the mutex argunme…
scherler Oct 28, 2022
7556d86
[yarn2] remove the target but set a default argument that can be over…
scherler Oct 31, 2022
b7b5e4e
[yarn2] fix formating
scherler Nov 2, 2022
b73c8ac
Merge branch 'master' into yarn2
scherler Nov 2, 2022
8afa526
Update pom.xml
scherler Nov 3, 2022
e076190
Update pom.xml
scherler Nov 4, 2022
a630140
[yarn2] Adopt PR feedback
scherler Nov 4, 2022
50f36bc
[yarn2] vscode should not have been committed
scherler Nov 4, 2022
738c258
[yarn2] remove legacy comment
scherler Nov 4, 2022
5e9ca32
Update pom.xml
scherler Nov 4, 2022
612216a
[yarn2] remove config section since it not needed
scherler Nov 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 67 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1361,6 +1361,73 @@
</plugins>
</build>
</profile>
<profile>
<id>yarn2-execution</id>
<activation>
<file>
<exists>.mvn_exec_yarn2</exists>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the same applied for yarn3? (the --mutex flag is a yarn 1 thing right?)

</file>
</activation>
<build>
<plugins>
<plugin>
<groupId>com.github.eirslett</groupId>
<artifactId>frontend-maven-plugin</artifactId>
<version>${frontend-version}</version>

<executions>

<execution>
<id>install node and yarn</id>
<goals>
<goal>install-node-and-yarn</goal>
</goals>
<phase>initialize</phase>
<configuration>
<nodeVersion>v${node.version}</nodeVersion>
<yarnVersion>v${yarn.version}</yarnVersion>
<nodeDownloadRoot>${nodeDownloadRoot}</nodeDownloadRoot>
<!-- tried to create a mirror for yarnDownloadRoot but it did not work -->
</configuration>
</execution>

<execution>
<id>yarn install</id>
<goals>
<goal>yarn</goal>
</goals>
<phase>initialize</phase>
</execution>

<execution>
<id>yarn mvnbuild</id>
<goals>
<goal>yarn</goal>
</goals>
<phase>generate-sources</phase>
<configuration>
<!-- The package.json must define an "mvnbuild" script -->
<arguments>run mvnbuild</arguments>
</configuration>
</execution>

<execution>
<id>yarn mvntest</id>
<goals>
<goal>yarn</goal>
</goals>
<phase>test</phase>
<configuration>
<!-- The package.json must define an "mvntest" script -->
<arguments>run mvntest</arguments>
</configuration>
</execution>

</executions>
</plugin>
</plugins>
</build>
</profile>
<profile>
<id>clean-node</id>
<activation>
Expand Down