Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HtmlUnit package for jacoco #778

Merged
merged 1 commit into from
Jun 6, 2023
Merged

Conversation

timja
Copy link
Member

@timja timja commented Jun 6, 2023

Before:

Caused by: org.jacoco.agent.rt.internal_4a7f17c.asm.MethodTooLargeException: Method too large: org/htmlunit/css/StyleAttributes$Definition.<clinit> ()V
	at org.jacoco.agent.rt.internal_4a7f17c.asm.MethodWriter.computeMethodInfoSize(MethodWriter.java:2088)
	at org.jacoco.agent.rt.internal_4a7f17c.asm.ClassWriter.toByteArray(ClassWriter.java:511)
	at org.jacoco.agent.rt.internal_4a7f17c.core.instr.Instrumenter.instrument(Instrumenter.java:92)
	at org.jacoco.agent.rt.internal_4a7f17c.core.instr.Instrumenter.instrument(Instrumenter.java:109)
	... 55 more

After nothing.

Note this issue doesn't cause any known issue other than spamming logs, but it is resolved again

Amends #777

Testing done

I ran mvn test -Dtest=InjectedTest -P enable-jacoco before and after this change on htmlunit 3.x

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@timja timja added the bug label Jun 6, 2023
@timja timja mentioned this pull request Jun 6, 2023
@timja timja merged commit 4589ac4 into jenkinsci:master Jun 6, 2023
@timja timja deleted the update-html-unit branch June 6, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants