Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-72317] Use Jenkins.READ permission check for all list box models #296

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

uhafner
Copy link
Member

@uhafner uhafner commented Nov 14, 2023

Additionally, use permissions for a BuildableItem in all validations.

See https://issues.jenkins.io/browse/JENKINS-72317 for details.

Additionally, use permissions for a `BuildableItem` in all validations.
@uhafner uhafner added the bug Bugs or performance problems label Nov 14, 2023
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d637752) 30.73% compared to head (848be3a) 30.73%.

Files Patch % Lines
...main/java/io/jenkins/plugins/util/QualityGate.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main     #296   +/-   ##
=========================================
  Coverage     30.73%   30.73%           
  Complexity       64       64           
=========================================
  Files            20       20           
  Lines           449      449           
  Branches         38       38           
=========================================
  Hits            138      138           
  Misses          308      308           
  Partials          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uhafner uhafner merged commit c092a14 into main Nov 14, 2023
29 of 30 checks passed
@uhafner uhafner deleted the permission-listbox branch November 14, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs or performance problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant