Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump org.jvnet.hudson.plugins:analysis-pom from 7.4.0 to 8.1.2 #359

Merged
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ name: 'GitHub CI'
on:
push:
branches:
- master
- main
pull_request:

Expand Down Expand Up @@ -34,4 +33,4 @@ jobs:
- name: Build with Maven
env:
BROWSER: chrome-container
run: mvn -V --color always -ntp clean verify --file pom.xml '-Djenkins.test.timeout=5000' '-Dgpg.skip'
run: mvn -V --color always -ntp clean verify '-Djenkins.test.timeout=5000' '-Pci'
2 changes: 1 addition & 1 deletion .github/workflows/codeql.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
queries: +security-and-quality

- name: Build with Maven
run: mvn -V --color always -ntp clean verify --file pom.xml -Pskip
run: mvn -V --color always -ntp clean verify -Pskip

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v3
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ name: 'CodeCov'
on:
push:
branches:
- master
- main
pull_request:

Expand All @@ -27,7 +26,7 @@ jobs:
with:
maven-version: 3.9.6
- name: Generate coverage with JaCoCo
run: mvn -V --color always -ntp clean verify '-Dgpg.skip'
run: mvn -V --color always -ntp clean verify -Pci
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v4.3.1
with:
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<parent>
<groupId>org.jvnet.hudson.plugins</groupId>
<artifactId>analysis-pom</artifactId>
<version>7.4.0</version>
<version>8.1.2</version>
<relativePath />
</parent>

Expand Down
1 change: 1 addition & 0 deletions src/main/java/io/jenkins/plugins/util/BuildAction.java
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ protected BuildAction(final Run<?, ?> owner, final T result) {
* determines whether the result should be persisted in the build folder
*/
@SuppressFBWarnings(value = "MC", justification = "getResultXmlPath() is a factory method and overridable by design")
@SuppressWarnings("PMD.ConstructorCallsOverridableMethod")
@VisibleForTesting
public BuildAction(final Run<?, ?> owner, final T result, final boolean canSerialize) {
this.owner = owner;
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/io/jenkins/plugins/util/QualityGate.java
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
}

private int asInt(final double value) {
return Double.valueOf(value).intValue();
return (int) value;

Check warning on line 65 in src/main/java/io/jenkins/plugins/util/QualityGate.java

View check run for this annotation

ci.jenkins.io / Code Coverage

Not covered line

Line 65 is not covered by tests
Dismissed Show dismissed Hide dismissed
}

/**
Expand Down
Loading