Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade maven-release-plugin to 3.0.0-M6 #281

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

olamy
Copy link
Member

@olamy olamy commented Jul 18, 2022

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@basil basil merged commit b6f23a6 into master Jul 18, 2022
@timja timja deleted the maven-release-plugin-to-3.0.0-M6 branch July 19, 2022 07:04
@basil
Copy link
Member

basil commented Aug 1, 2022

Causes JENKINS-69198.

@jglick
Copy link
Member

jglick commented Aug 2, 2022

#296

@daniel-beck
Copy link
Member

daniel-beck commented Sep 21, 2022

Caused (or contributed to) jenkins-infra/helpdesk#3143.

"M" is milestone, right? Why are we using prerelease versions of dependencies?

@basil
Copy link
Member

basil commented Sep 21, 2022

jenkinsci/plugin-pom#558 did not contain a description of the change, let alone its motivation or the reasoning behind it.

@olamy
Copy link
Member Author

olamy commented Sep 21, 2022

jenkinsci/plugin-pom#558 did not contain a description of the change, let alone its motivation or the reasoning behind it.

motivation was this issue https://issues.apache.org/jira/browse/MRELEASE-1025 (some contributors had this issue).
Sorry if I didn't write that but I was trying to act as dependabot does (e.g no motivation) :)

Is there any issue logged in https://issues.apache.org/jira/projects/MRELEASE?
I can have a look when back from holidays.

@basil
Copy link
Member

basil commented Sep 21, 2022

"M" is milestone, right? Why are we using prerelease versions of dependencies?

Unclear to me, but both https://maven.apache.org/surefire/maven-surefire-plugin/ and https://maven.apache.org/maven-release/maven-release-plugin/ show "M" versions, and the last releases without an M were released in 2019 and 2015 respectively. Dependabot did not offer them specifically because they have an M and are considered prerelease, but if the Maven project considered them prereleases and was recommending a non-prerelease version for general usage, why would the web pages show the prerelease version, and why would the general usage version be so many years old? Does not make sense to me.

@jglick
Copy link
Member

jglick commented Sep 22, 2022

some contributors had this issue

Contributors on Windows? They could switch to JEP-229 and never need to run MRP locally again, saving the lives of multiple kittens. :trollface:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants