Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use upstream Spotless configuration #254

Merged
merged 1 commit into from
Apr 15, 2023
Merged

Conversation

basil
Copy link
Member

@basil basil commented Apr 12, 2023

This repository had its own custom Spotless configuration. Moving to the project-wide upstream configuration should make it easier to maintain this plugin.

@github-actions github-actions bot added dependencies Dependency related change test Automated test addition or improvement labels Apr 12, 2023
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jenkins Security Scan found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@basil
Copy link
Member Author

basil commented Apr 12, 2023

The security scan result is a false positive. These were existing issues that are being flagged again because the line numbers have changed.

@MarkEWaite MarkEWaite added chore Reduces maintenance effort by changes not directly visible to users and removed dependencies Dependency related change test Automated test addition or improvement labels Apr 15, 2023
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MarkEWaite MarkEWaite merged commit f8adedf into jenkinsci:master Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Reduces maintenance effort by changes not directly visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants