Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove flaky test #320

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Conversation

MarkEWaite
Copy link
Contributor

Remove flaky test

Practicing what I regularly preach. I don't have time or energy to determine why the test is flaky. There are several other tests in the same file. Delete the flaky test rather than continuing to be distracted by it.

Testing done

Before this change, 2 of 10 test runs failed on my computer. After this change, 16 of 16 tests runs passed.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@MarkEWaite MarkEWaite requested a review from a team as a code owner December 15, 2023 00:49
@github-actions github-actions bot added the tests Automated test addition or improvement label Dec 15, 2023
@MarkEWaite MarkEWaite merged commit c87f732 into jenkinsci:master Dec 15, 2023
2 of 4 checks passed
@MarkEWaite MarkEWaite deleted the remove-flaky-test branch December 15, 2023 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Automated test addition or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant