Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh plugin #51

Merged
merged 11 commits into from
Mar 3, 2021
Merged

Refresh plugin #51

merged 11 commits into from
Mar 3, 2021

Conversation

timja
Copy link
Member

@timja timja commented Jan 22, 2021

cc @fr123k

extracted mostly from your PR, as I need to make a change to this plugin and didn't want to do it on top of your massive PR

@timja timja closed this Jan 22, 2021
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes look good. Thanks for avoiding the binary compatibility changes for now. This codebase is really dated, and a larger push would be required to modernize it.

@@ -28,7 +28,6 @@
/**
* Implements descriptor for {@link SorterStrategy}.
*
* @author Oleg Nenashev <nenashev@synopsys.com>, Synopsys Inc.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was breaking for invalid 'html', when I went to check the correct syntax the top 2 articles just recommended removing them, e.g. https://www.vojtechruzicka.com/stop-using-javadoc-author-tag/

any objection @oleg-nenashev

@timja
Copy link
Member Author

timja commented Jan 23, 2021

build is green now

Copy link
Contributor

@fr123k fr123k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a local test and everything green. LGTM

I will rebase my #50 after the merge.

@timja I'am quite new to jenkins-ci repositories.
Can i approach you for questions and help.

Thanks

@timja
Copy link
Member Author

timja commented Jan 25, 2021

@timja I'am quite new to jenkins-ci repositories.
Can i approach you for questions and help.

In general the preference is to use mailing lists and chat rooms rather than individual help, this helps prevent people getting overwhelmed and being blocked on a single person, I would prefer any questions are asked in the open and feel free to point me towards them if you need help and I can try but I do have limited time.

@oleg-nenashev
Copy link
Member

OK, time to merge it then

@oleg-nenashev oleg-nenashev merged commit ae64bdf into jenkinsci:master Mar 3, 2021
@oleg-nenashev oleg-nenashev added the chore Reduces maintenance effort by changes not directly visible to users label Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Reduces maintenance effort by changes not directly visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants