-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh plugin #51
Refresh plugin #51
Conversation
* update the pom definition to the jenkins plugin version 4.1 * update the plugin specific code to support plugin version 4.1 and be fully compatible with the casc plugin (configuration as code)
This documentation ia auto generated. https://plugins.jenkins.io/release/#dependencies
The maintainer information is extracted from the [repository-permissions-updater](https://github.com/jenkins-infra/repository-permissions-updater) instead. [WEBSITE-658](https://issues.jenkins-ci.org/browse/WEBSITE-658)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All changes look good. Thanks for avoiding the binary compatibility changes for now. This codebase is really dated, and a larger push would be required to modernize it.
@@ -28,7 +28,6 @@ | |||
/** | |||
* Implements descriptor for {@link SorterStrategy}. | |||
* | |||
* @author Oleg Nenashev <nenashev@synopsys.com>, Synopsys Inc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was breaking for invalid 'html', when I went to check the correct syntax the top 2 articles just recommended removing them, e.g. https://www.vojtechruzicka.com/stop-using-javadoc-author-tag/
any objection @oleg-nenashev
build is green now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a local test and everything green. LGTM
I will rebase my #50 after the merge.
@timja I'am quite new to jenkins-ci repositories.
Can i approach you for questions and help.
Thanks
In general the preference is to use mailing lists and chat rooms rather than individual help, this helps prevent people getting overwhelmed and being blocked on a single person, I would prefer any questions are asked in the open and feel free to point me towards them if you need help and I can try but I do have limited time. |
OK, time to merge it then |
cc @fr123k
extracted mostly from your PR, as I need to make a change to this plugin and didn't want to do it on top of your massive PR