-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the Jenkins colour palette #161
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the colors, it totally makes sense to provide a Jenkins theme.
@@ -8,7 +8,7 @@ | |||
* @author Ullrich Hafner | |||
*/ | |||
public enum PrismTheme { | |||
PRISM("Default (light and dark mode)", "prism.css"), | |||
PRISM("Default (light and dark mode)", "default.css"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove the assertion in the Test:
.extracting(PrismTheme::getFileName)
.isEqualTo("prism.css")
It actually does not verify anything useful and can be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done - want the entire assertion removed or just those two lines? Thanks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #161 +/- ##
============================================
- Coverage 75.59% 75.39% -0.20%
- Complexity 91 93 +2
============================================
Files 13 13
Lines 377 378 +1
Branches 30 30
============================================
Hits 285 285
- Misses 89 90 +1
Partials 3 3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Would be good to hear your thoughts on this @uhafner -
Currently the Prism plugin uses its default colour palette which differs from the Jenkins palette. This PR looks to set the default theme to follow Jenkins' palette instead. This brings a couple of advantages:
.withProperty("prism-api", "theme", PRISM_THEME)
from that plugin)Before
After
Testing done
Submitter checklist