Cleanup and modernization for RemoteClassLoader #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffret-b
added
the
chore
varyvol
reviewed
Apr 17, 2020
| @@ -322,7 +323,6 @@ ClassReference toRef(ClassFile2 cf) { | |||
| // but we need to remember to set the interrupt flag back on | |||
| // before we leave this call. | |||
| interrupted = true; | |||
| continue; // JENKINS-19453: retry | |||
There was a problem hiding this comment.
I don't think so. As IntelliJ says, "'continue' is unnecessary as the last statement in a loop ".
Because of the depth of the loops it's hard to read and the GH UI here doesn't make it any easier.
There was a problem hiding this comment.
Looks like a redundant continue as it's the end of the block.
There was a problem hiding this comment.
Makes sense, thanks for the clarification!
jvz
approved these changes
Apr 17, 2020
| @@ -322,7 +323,6 @@ ClassReference toRef(ClassFile2 cf) { | |||
| // but we need to remember to set the interrupt flag back on | |||
| // before we leave this call. | |||
| interrupted = true; | |||
| continue; // JENKINS-19453: retry | |||
There was a problem hiding this comment.
Looks like a redundant continue as it's the end of the block.
varyvol
approved these changes
Apr 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some simple modernization and cleanup for RemoteClassLoader. These changes are all refactorings with no change in behavior.
Once I get this approved and merged I've got a couple more cleanup PRs to process and then some actual improvements to RemoteClassLoader.