Reference new tcp-agent-listener endpoint #457
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
requested changes
May 18, 2021
Comment on lines
379
to
+381
| return jenkinsUrl.endsWith("/") | ||
| ? new URL(jenkinsUrl + "tcpSlaveAgentListener/") | ||
| : new URL(jenkinsUrl + "/tcpSlaveAgentListener/"); | ||
| ? new URL(jenkinsUrl + "tcp-agent-listener/") | ||
| : new URL(jenkinsUrl + "/tcp-agent-listener/"); |
|
jenkinsci/jenkins#5495 was closed so I think this is obsolete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstream of jenkinsci/jenkins#5495
It is unclear to me what the compatibility requirements of remoting are. This is a very simple patch that assumes remoting can be older (~minimum version defined in core), but never newer.
Also noting two TODOs where further cleanup can be done once jenkinsci/jenkins#5494 is released or developer documentation migrated away from the wiki.