Pass through the remote ClassLoader’s name
#741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtnord
force-pushed
the
debug
branch
2 times, most recently
from
dcb8d41 to
e55daa8
Compare
jtnord
force-pushed
the
debug
branch
3 times, most recently
from
d8ef923 to
96d6148
Compare
jtnord
commented
May 14, 2024
14 tasks
jtnord
added
the
enhancement
add getName to the IClassloader and set a name in the RemoteClassLoader This improves the debugability from RemoteClassloaders to understand any classloading related issues.
jtnord
commented
May 15, 2024
|
|
||
| /** | ||
| * Name of the classLoader | ||
| * @since 3242 |
There was a problem hiding this comment.
assumes this will be the next thing released
There was a problem hiding this comment.
I do not think we bother with @since in CD-versioned components, though it is possible.
olamy
approved these changes
May 15, 2024
jglick
changed the title
ClassLoader’s name
jglick
approved these changes
May 15, 2024
|
|
||
| /** | ||
| * Name of the classLoader | ||
| * @since 3242 |
There was a problem hiding this comment.
I do not think we bother with @since in CD-versioned components, though it is possible.
If we can not obtain the name of the classloader then add the proxies identityHashCode so they will be unique amongst all others.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing done
Created a version of Jenkins with a local build of this, attached a debugger to an
ssh-slavesagent and put a breakpoint on some code that runs in the agent (from the git-client plugin) to observe classloading.See jenkinsci/jenkins#9277
Submitter checklist