set since to released version #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtnord
commented
May 15, 2024
| @@ -898,7 +898,7 @@ public interface IClassLoader { | |||
|
|
|||
| /** | |||
| * Name of the classLoader | |||
| * @since 3242 | |||
| * @since 3244.vf7f977e04755 | |||
There was a problem hiding this comment.
NotMyFault
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sets the since version https://github.com/jenkinsci/remoting/pull/741/files#r1601332693 to the actual release version.
There is no need for this as the version in the code is higher than the previous release without this method and lower than the version with this method. But it's wrong and it makes me feel dirty :)
Testing done
Submitter checklist