Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with guava 33.3.1-jre, same as Jenkins core #765

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

MarkEWaite
Copy link
Contributor

Test with guava 33.3.1-jre, same as Jenkins core

Guava versions prior to 32.0.0 have two issues reported:

Neither of those issues is any risk to production because this is a test dependency. However, since Jenkins core is using Guava 33.3.1-jre, let's upgrade this test dependency to use the same Guava version and resolve the dependabot alerts at the same time.

Testing done

Confirmed that mvn clean verify passes with Java 11 and Java 21 on my Linux computer.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Guava versions prior to 32.0.0 have two issues reported:

* https://github.com/jenkinsci/remoting/security/dependabot/4
  Guava vulnerable to insecure use of temporary directory
* https://github.com/jenkinsci/remoting/security/dependabot/3
  Information Disclosure in Guava

Neither of those issues is any risk to production because this is a
test dependency.  However, since Jenkins core is using Guava 33.3.1-jre,
let's upgrade this test dependency to use the same Guava version and
resolve the dependabot alerts at the same time.
@MarkEWaite MarkEWaite added the test label Oct 8, 2024
@timja timja merged commit 9501bdc into jenkinsci:master Oct 8, 2024
14 checks passed
@MarkEWaite MarkEWaite deleted the update-guava-test-dependency branch October 8, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants