fix spotbugs

jenkinsci · Dec 29, 2022 · cf2f554 · cf2f554
1 parent a6eece5
commit cf2f554
Showing 1 changed file with 7 additions and 11 deletions.
diff --git a/...ain/java/com/michelin/cio/hudson/plugins/rolestrategy/RoleBasedAuthorizationStrategy.java b/...ain/java/com/michelin/cio/hudson/plugins/rolestrategy/RoleBasedAuthorizationStrategy.java
@@ -1080,21 +1080,17 @@ private void readRoles(JSONObject formData, final RoleType roleType, RoleBasedAu
         }
         RoleMap roleMap = oldStrategy.getRoleMap(roleType);
         boolean generated = false;
-        if (roleMap != null) {
-          Role oldRole = roleMap.getRole(roleName);
-          if (oldRole != null) {
-            generated = oldRole.isGenerated();
-          }
+        Role oldRole = roleMap.getRole(roleName);
+        if (oldRole != null) {
+          generated = oldRole.isGenerated();
         }
         Role role = new Role(roleName, Pattern.compile(pattern), permissions, "", generated);
         targetStrategy.addRole(roleType, role);
 
-        if (roleMap != null) {
-          Set<String> sids = roleMap.getSidsForRole(roleName);
-          if (sids != null) {
-            for (String sid : sids) {
-              targetStrategy.assignRole(roleType, role, sid);
-            }
+        Set<String> sids = roleMap.getSidsForRole(roleName);
+        if (sids != null) {
+          for (String sid : sids) {
+            targetStrategy.assignRole(roleType, role, sid);
           }
         }
       }