Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add case sensitive help #10

Merged

Conversation

fbelzunc
Copy link
Contributor

Users still try to add groups in Jenkins which are not exactly written in the same way they are using in their Access Control, e.g. LDAP, AD, ...

Hopefully, some of them will read the help button and will figure out that it is indeed case sensitive and it needs to be written in the same way.

@reviewbybees

<!--
- The MIT License
-
- Copyright (c) 2010, Manufacture Française des Pneumatiques Michelin, Thomas Maurel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong copyright

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ups. Right. Just copy/paste sorry. I am modifying it.

@oleg-nenashev
Copy link
Member

The text looks good for me. BTW, we still need a case-insensitive mode (e.g. draft implementation from #5)

@fbelzunc
Copy link
Contributor Author

@oleg-nenashev @KostyaSha I have just removed the copyright.

@oleg-nenashev
Copy link
Member

Thanks for your contribution!
Please merge changes into a single commit. I'll merge the PR after it.

@fbelzunc fbelzunc force-pushed the ZD-25838-case-sensitive-help branch from 05f79df to adbc534 Compare April 14, 2015 08:17
@fbelzunc
Copy link
Contributor Author

@oleg-nenashev done!

oleg-nenashev added a commit that referenced this pull request Apr 14, 2015
@oleg-nenashev oleg-nenashev merged commit d6b7860 into jenkinsci:master Apr 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants