Upgrade to pac4j 6.x, require Java 17 or newer, and migrate to EE 9 #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil
commented
Oct 8, 2024
| @@ -1,6 +1,6 @@ | |||
| #!/usr/bin/env groovy | |||
|
|
|||
| buildPlugin(useContainerAgent: true, configurations: [ | |||
| buildPlugin(useContainerAgent: false, configurations: [ | |||
There was a problem hiding this comment.
To run LiveTest on CI builds.
Comment on lines
+60
to
+61
| SAML2Credentials unvalidated = (SAML2Credentials) client.getCredentials(ctx).orElse(null); | ||
| credentials = (SAML2AuthenticationCredentials) client.validateCredentials(ctx, unvalidated).orElse(null); |
There was a problem hiding this comment.
Per the migration guide, the getCredentials method has been split into the getCredentials and validateCredentials methods.
| * Note: It does not call the logout service on SAML because the library does not implement it on this version, | ||
| * it will be done when we upgrade the library. | ||
| */ | ||
| @SuppressWarnings("deprecation") | ||
| @Override | ||
| protected String getPostLogOutUrl(StaplerRequest req, @NonNull Authentication auth) { | ||
| protected String getPostLogOutUrl2(StaplerRequest2 req, @NonNull Authentication auth) { |
There was a problem hiding this comment.
Migrating from Acegi to Spring Security.
kuisathaverat
approved these changes
Oct 9, 2024
|
It will trigger a release. Thanks for the changes. |
basil
commented
Oct 9, 2024
Comment on lines
606
to
607
| * Note: It does not call the logout service on SAML because the library does not implement it on this version, | ||
| * it will be done when we upgrade the library. |
There was a problem hiding this comment.
@kuisathaverat Now that the library has been upgraded, this task can be completed. From the blog post:
The
processLogoutmethod has been added, based on theLogoutProcessorcomponent.
There was a problem hiding this comment.
I have limited time, I do not plan to do it soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pac4j.org/blog/what_s_new_in_pac4j_v6.html