Fix class not found exception without Subversion plugin #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://issues.jenkins.io/browse/JENKINS-64985
A
ClassNotFoundException
was thrown while creating namespace jobs, when the Subversion plugin is not installed. The stack trace looked something like this:This was due to a reference to a classes only available in the Subversion plugin in
ScmManagerSvnSource
, and that class in turn was a part of the public API ofScmManagerSvnSourceBuilder
due to the generic. But this class is used inScmManagerNavigator.ScmManagerSvnSourceBuilder
and therefore has to be loaded when a job shall be created.By using
SCMSource
in the generic instead of the special implementation of the Subversion plugin, we can remove this class from the public API, and therefore this class no longer needs to be loaded unless it is needed.