Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax uri comparison #29

Merged
merged 2 commits into from
Feb 17, 2022
Merged

Relax uri comparison #29

merged 2 commits into from
Feb 17, 2022

Conversation

sdorra
Copy link
Contributor

@sdorra sdorra commented Feb 17, 2022

Ensure that http, https and ssh urls without port treated as the same if the default port is included in the url.
Credentials, query parameters and hash urls are ignored for the equality check.
This should fix sending of notifications in which the source url does not contain the port, but the scm url contains a default port.

JENKINS-67588

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@sdorra sdorra added the bug Something isn't working label Feb 17, 2022
@sdorra sdorra requested a review from pfeuffer February 17, 2022 06:13
@pfeuffer pfeuffer merged commit 10796ac into master Feb 17, 2022
@pfeuffer pfeuffer deleted the bugfix/relax_uri_comparison branch February 17, 2022 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants