Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JENKINS-14964 Allow running scripts using the REST API #15

Merged
merged 3 commits into from
Feb 10, 2014

Conversation

agudian
Copy link
Contributor

@agudian agudian commented Jan 24, 2014

See JENKINS-14964.

It allows you to run a script using the URL /scriptler/run/?param1=value1 (or the POST equivalent).
The parameters node, script (alternative script source), and contentType (for the response) are also available.

Would be happy seeing it applied. :)

@cloudbees-pull-request-builder

plugins » scriptler-plugin #15 UNSTABLE
Looks like there's a problem with this pull request

@agudian
Copy link
Contributor Author

agudian commented Jan 24, 2014

Test fails due to the wrong URL, see PR #14

@imod
Copy link
Member

imod commented Feb 1, 2014

nice one!
can you please also add a test case?

@agudian
Copy link
Contributor Author

agudian commented Feb 1, 2014

can you please also add a test case?

Sure, added a small one. I left out testing the node parameter for now, but maybe you have a hint on how to add some node configuration in the test framework?

@cloudbees-pull-request-builder

plugins » scriptler-plugin #20 UNSTABLE
Looks like there's a problem with this pull request

@agudian
Copy link
Contributor Author

agudian commented Feb 3, 2014

@imod, if you want me to rebase and squash my commits into one, please let me know. Same for PR #16 :)

@imod
Copy link
Member

imod commented Feb 3, 2014

no problem - there are some other things I'll change on this too: e.g. internationalization of the exception message.
I'll merge it in the next couple of days.

@agudian
Copy link
Contributor Author

agudian commented Feb 3, 2014

OK, great. Thanks!

@imod imod merged commit c6e3712 into jenkinsci:master Feb 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants