[JENKINS-21327] replace RUN_SCRIPTS with a new Scriptler RUN permission #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
reviewed
May 16, 2017
| tokenmacro_ScriptDoesNotExist = No script with the id [{0}] could be found. | ||
| permissons_title = Scriptler | ||
| permissons_run_description = allow execution of scritpler scripts |
| @@ -65,6 +68,9 @@ | |||
| private final static String ALL = "(all)"; | |||
| private final static String ALL_SLAVES = "(all slaves)"; | |||
|
|
|||
| public static final PermissionGroup SCRITPLER_PERMISSONS = new PermissionGroup(ScriptlerManagement.class, Messages._permissons_title()); | |||
|
@jglick hmm, from my POV this is logical consequence if I want to allow some users (non admins) to execute/use scriptler scripts. |
|
@daniel-beck do you understand what @jglick is talking about? I really don't get it anymore some more context information in the answers would really help... |
|
Probably best to try to make scripts I hope I'll have the time in the next two weeks to investigate this further. |
|
Superseded by #32, I think. |
|
closing because of #32 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this should replace the use of
RUN_SCRIPTwith a new Scriptler specificRUNpermisson