Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hacktoberfest docs-to-code migration #27

Merged
merged 2 commits into from
Oct 20, 2021

Conversation

Dan-Heath
Copy link
Contributor

@Dan-Heath Dan-Heath commented Oct 19, 2021

This PR copies the Sidebar Link plugin Readme information from the plugins-wiki-docs repo to the sidebar-link-plugin repo and update the pom.xml URL as part of the Hacktoberfest docs-to-code project. For this plugin, the only content missing from the existing Readme file was the Change Log.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did

@Dan-Heath
Copy link
Contributor Author

Hello @damianszczepanik , I created this PR as part of the Hacktoberfest docs-to-code project. I believe it is ready to be reviewed and merged. Please let me know if you have any questions. Thank you!

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to move the changelog into a standard CHANGELOG.md file

README.md Outdated
##### Version 1.0 (17-Dec-2008)

- Initial release.

See also:
- [Jenkins Wiki - Sidebar Link Plug-in](https://wiki.jenkins-ci.org/display/JENKINS/Sidebar-Link+Plugin)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be removed now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @oleg-nenashev ! I created a CHANGELOG.md file and moved that info out of the Readme. I also deleted the link above to the Jenkins wiki.

@damianszczepanik damianszczepanik merged commit a83a804 into jenkinsci:master Oct 20, 2021
@damianszczepanik
Copy link
Member

@Dan-Heath I'm impressed of the changelog :)

@Dan-Heath
Copy link
Contributor Author

@Dan-Heath I'm impressed of the changelog :)

Thanks @damianszczepanik ! I agree, that was a great suggestion from Oleg :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants