-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CHANGELOG.md for existing versions up to 2.1.0 #39
Update CHANGELOG.md for existing versions up to 2.1.0 #39
Conversation
Some earlier versions are missing as well. |
@KalleOlaviNiemitalo If you need help with CD release and release draft I can help with that (I used it few days ago with some plugin I maintain : https://github.com/jenkinsci/openshift-k8s-credentials-plugin) But basically you can follow this guide to adapt the maven config for incrementals and template of workflow files : https://www.jenkins.io/doc/developer/publishing/releasing-cd/ Regards |
In any case, I think I should populate CHANGELOG.md for the existing releases. If Release Drafter is later deployed, those entries can then be copied to the releases on GitHub, whether this PR is merged or not. |
I'm happy to accept this but now this is in review state. Is it by purpose? |
Yes, I'd like to first add information about some older versions that are not currently listed. |
Also, the date formats are inconsistent. |
Promote the level-2 heading to level 1, and the level-5 headings to level 2.
This should make the change log easier to find from <https://plugins.jenkins.io/sidebar-link/#documentation>.
CHANGELOG.md
Outdated
|
||
## Version 2.0.2 (2022-02-12) | ||
|
||
- Fix number hpi.forcompatibleSinceVersion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The element in pom.xml is actually hpi.compatibleSinceVersion
.
Line 19 in 45a4157
<hpi.compatibleSinceVersion>2.0.0</hpi.compatibleSinceVersion> |
Great job - thank you! |
The README change has now propagated to https://plugins.jenkins.io/sidebar-link/#documentation. |
Update CHANGELOG.md so it describes all existing versions from 1.0 to 2.1.0. Add a link from README.md to CHANGELOG.md.
Preferably, the release notes should be in GitHub releases like https://github.com/jenkinsci/sidebar-link-plugin/releases/tag/sidebar-link-2.1.0 so that https://plugins.jenkins.io/sidebar-link/#releases would display them. I cannot make a pull request to those, though.
Related to #21, which suggests using Release Drafter. I have no experience with that.