Fix #126 Replace <a> tags with Slack <link|name> #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frodeaa
changed the title
|
@kmadel can this please be merged? Thanks a lot |
|
@kmadel could you please take a look at this PR? |
frodeaa
force-pushed
the
a-tag-format-escape
branch
from
82d7103 to
d2f8663
Compare
|
any chance this could be rebased and reviewed so it gets included in the 2.1 release? i'd really love to see this fixed. |
|
Once latest changes are merged from master, this is a candidate for 2.2 |
frodeaa
force-pushed
the
a-tag-format-escape
branch
from
d2f8663 to
b9791af
Compare
Replace <a href...>text</a> with <url|text> before escaping the remaining parts of the message fixes jenkinsci#126 fixes nishio-dens/bitbucket-pullrequest-builder-plugin#59
|
Feel free to subscribe to #296 for updates related to Slack Plugin 2.2 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
<a href...>text</a>with<url|text>beforeescaping the remaining parts of the message
fixes #126
fixes nishio-dens/bitbucket-pullrequest-builder-plugin#59