Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML is not escaped properly #59

Closed
tnguyen14 opened this issue Sep 4, 2015 · 9 comments · Fixed by jenkinsci/slack-plugin#222
Closed

HTML is not escaped properly #59

tnguyen14 opened this issue Sep 4, 2015 · 9 comments · Fixed by jenkinsci/slack-plugin#222
Labels
aged out Reporter went idle, or too much time has passed to validate

Comments

@tnguyen14
Copy link

Attached are 2 screenshots that describe this problem. The first one is on the builds listing on the left side of the job.
jenkins-jobs

The second one is on Slack when I integrate with the Slack plugin
slack notification
@jwismar
Copy link

jwismar commented Sep 4, 2015

There is a Jenkins configuration setting that controls that. It's under "Manage Jenkins > Configure Global Security". There's a drop down labelled "Markup Formatter". Change the setting from "Escaped HTML" to "Safe HTML".

@tnguyen14
Copy link
Author

I see "Escaped HTML" and "Raw HTML". Is "Raw HTML" the one I'd want?

@jwismar
Copy link

jwismar commented Sep 4, 2015

There must be another setting or plugin that enables the "Safe HTML" option, but I can't find it right now. But yes, I think that the "Raw HTML" setting will fix this problem for you.

@tnguyen14
Copy link
Author

Is it this plugin https://wiki.jenkins-ci.org/display/JENKINS/OWASP+Markup+Formatter+Plugin?

@tnguyen14
Copy link
Author

Update: I do have the "OWASP Markup Formatter Plugin" installed. However, it was at version 1.1. When I updated it to version 1.3, the second option appears as "Safe HTML" and not "Raw HTML".

This seems to fix the issue with the builds list. Once I can confirm that the slack notifications are also formatted correctly, I'll close this issue.

@tnguyen14
Copy link
Author

Just to follow up - the slack notifications are still showing the unescaped HTML. I am not sure if this would be an bug for the Slack plugin repo or for this repo...

@joshskinner
Copy link

+1 on the slack integrations

@tnguyen14
Copy link
Author

Related jenkinsci/slack-plugin#126

@maxvodo
Copy link
Contributor

maxvodo commented Feb 2, 2016

Check this later

frodeaa added a commit to frodeaa/slack-plugin that referenced this issue May 27, 2016
@frodeaa
Replace <a> tags with Slack <link|name>
82d7103 
Replace <a href...>text</a> with <url|text> before
escaping the remaining parts of the message

fixes jenkinsci#126
fixes nishio-dens/bitbucket-pullrequest-builder-plugin#59
@frodeaa frodeaa mentioned this issue May 27, 2016
Merged
frodeaa added a commit to frodeaa/slack-plugin that referenced this issue Oct 21, 2016
@frodeaa
Replace <a> tags with Slack <link|name>
d2f8663 
Replace <a href...>text</a> with <url|text> before
escaping the remaining parts of the message

fixes jenkinsci#126
fixes nishio-dens/bitbucket-pullrequest-builder-plugin#59
frodeaa added a commit to frodeaa/slack-plugin that referenced this issue Nov 16, 2016
@frodeaa
Replace <a> tags with Slack <link|name>
b9791af 
Replace <a href...>text</a> with <url|text> before
escaping the remaining parts of the message

fixes jenkinsci#126
fixes nishio-dens/bitbucket-pullrequest-builder-plugin#59
@CodeMonk CodeMonk added the aged out Reporter went idle, or too much time has passed to validate label Oct 8, 2018
@CodeMonk CodeMonk closed this as completed Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
aged out Reporter went idle, or too much time has passed to validate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #126 Replace <a> tags with Slack <link|name> frodeaa/slack-plugin
5 participants
@CodeMonk @joshskinner @tnguyen14 @jwismar @maxvodo