Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Credentials Support with credentials select widget [JENKINS-35503] #247

Merged
merged 11 commits into from
Oct 26, 2016

Conversation

kmadel
Copy link
Contributor

@kmadel kmadel commented Sep 10, 2016

Most importantly, this is a fix for JENKINS-35503. Based on work done in PR #208
Example of integrating with xmlns:c="/lib/credentials" c:select for selecting credentials. Feel free to merge or not.

Create credential set:
image

Apply to Slack configuration:
image

@kmadel
Copy link
Contributor Author

kmadel commented Sep 10, 2016

Looking for two thumbs up - and then we will get this merged and released.

@samrocketman
Copy link
Member

samrocketman commented Sep 10, 2016

cc @fgs-dbudwin
edit: currently upgrading my scripts to test this change.

@samrocketman
Copy link
Member

👍 from me

My testing is completed:

  • PASS -Sucessfully build this pull request and pass unit tests
  • PASS - Upgrade from Slack plugin 2.0.1 to this pull request version and see how upgrades behave.
  • PASS - Configure new credentials ID with the slack plugin and test with it. It should behave the same.
  • PASS - Test connection button with credentials ID configured.

How was testing prepared?

git clone https://github.com/samrocketman/jenkins-bootstrap-slack
cd jenkins-bootstrap-slack/
#ensure that no services are listening on iface:port localhost:8080
./slack_bootstrap.sh
#follow instructions to log into Jenkins at the end of the script output

I then visited https://jenkins-slack-plugin.slack.com/ to see how slack messages were posted during my tests.

@kmadel kmadel merged commit 40a0ac4 into jenkinsci:master Oct 26, 2016
@kmadel kmadel added this to the slack-2.1 milestone Nov 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants