-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add display failed tests option to slack notifications on job configuration #275
Conversation
Please rebase on master and resolve merge conflicts. |
@samrocketman rebased and resolved conflicts. |
@derinbay if you've rebased, then why are there so many commits? |
@samrocketman I guess I messed up with the rebase and made a merge from master instead, sorry about that.. Should I revert? |
@derinbay Do not revert. Cherry pick the merge commit onto a new branch based on Note: I haven't tested the following method. I will test it tomorrow to be sure the commands are correct. #from your own repository
git remote add upstream https://github.com/jenkinsci/slack-plugin
git fetch upstream
git checkout failed-tests-report
#rename the branch
git branch -m old-failed-tests-report
#create a new branch
git checkout upstream/master -b failed-tests-report
#get all of the changes as a single commit
git cherry-pick -m 2 old-failed-tests-report
#reuse metadata from your original commit
git commit --amend --reuse-message=1c86334fd262bd5a3caa82aeab6faab74948e2e9 Now you should be one commit ahead of upstream master. #status should say you're one commit ahead of upstream/master
git status
#inspect your commit to ensure it is correct
git show HEAD If everything looks okay to you then force push it to overwrite your branch. If you're unsure, then feel free to give me write access to your repository and I can fix it for you. |
0cfdbd8
to
a57ac02
Compare
@samrocketman Made some stuff but not sure if it's ok. First it was fine but then I revert back my last commit, that commit resolves a duplication which is not exist anymore, probably it was happened during the merge yesterday, so it was unnecessary. I've added you as collaborator to my repo. I'll be glad if you check. Thanks |
@derinbay I think you mistakenly messed up your branch. The PR shows |
55b3d78
to
2cac73c
Compare
@samrocketman Ok I found the codes and saw that #166 was almost same development with this one. I've added the differences to this commit, that shows the duration of the failed test and fixed a lower case letter (I guess a typo) |
Looks good. I'm going to test it before merging. Thanks for your contribution. |
Feel free to subscribe to #296 for updates related to Slack Plugin 2.2 release. |
Is it possible to send results in a pipeline using slackSend? |
I've added an option as "Include Failed Tests" to slack notifications on job configuration screen to display failed tests.
PR#166 also adds the failed tests but I think there should be an option for user to choose on configurations. Also there was a conflict on that PR and it was very old, so I've opened this one.