Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge PR #197 Fix #62 by excluding empty affected #291

Merged
merged 2 commits into from
Mar 2, 2017
Merged

Conversation

samrocketman
Copy link
Member

files collection. This was thoroughly tested by me. This PR only serves to update #197 with master so it can be merged.

yestin and others added 2 commits March 18, 2016 17:37
Jenkins Repo plugin adds an "empty" change log when there is a
new project added or removed, e.g.:

path: local/path
serverPath: server/path
revision: null
authorName: null
authorEmail: null
authorDate: null
committerName: null
committerEmail: null
committerDate: null
commitText: This project was added from the manifest.
modifiedFiles: null

When Slack plugin tries to add the "null" affected files, it gets a
NullPointerException error.

Fix the error by not adding any empty affected files collection.
@samrocketman samrocketman merged commit 483add3 into master Mar 2, 2017
@samrocketman samrocketman deleted the pr-197 branch March 2, 2017 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants