Rebase and resolve original PR #156 to fix issue #102 from nevermindr #299
Conversation
jiamengyu
changed the title
|
Please squash your commits into a single commit. Once you do that, I'll review and do some testing of my own. |
|
Also, ensure your squashed commit is rebased on the latest master. If you don't know how to squash commits then please give me write access to your repository. I can squash it for you. |
|
@samrocketman Have invited you to my reposiroty and given write access. Please squash as needed. Thank you a lot for helping. |
jiamengyu
force-pushed
the
master
branch
2 times, most recently
from
b4e3df4 to
756f3e7
Compare
|
Done with squashing into single commit. |
|
@jiamengyu I'm going to update your commit authorship to attribute @nevermindr. I'll test this evening. |
with org.apache.http.impl.client.CloseableHttpClient added httpclient4.3.2 dependency fixed tests * HttpClientStub -> CloseableHttpClientStub * getContent on response object fixed
* Use CloseableHttpClient to replace HttpClient implementation * Updated test cases with CloseableHttpClientStub * Optimize CloseableHttpClient Response manipulation. * Rebased jenkinsci#156 on latest master
|
@jiamengyu I have rebased and tried to retain the authorship from both #156 and this PR. Please approve. cc @nevermindr |
|
Where can I approve? is there a button? or what action need to be done for approval? |
|
@jiamengyu I just wanted you to see what I did and approve with a simple comment. I wanted to be sure I wasn't doing something you didn't like. I'm currently testing this for merge. |
|
@samrocketman I've reviewed all the changes one more time, looks all good! Please proceed with merging if all testing passed. |
|
double posting from #148 to try and get a response from a party who is watching... Can anyone please give me some insight here. I'm trying to use this plugin in my Jenkins Pipeline build behind a proxy in an enterprise environment. slackSend isn't honoring http_proxy, https_proxy, or HTTP_PROXY, HTTPS_PROXY or -Dhttp.proxyHost or -Dhttps.proxyHost. I know Jenkins use the proxy by leveraging one of the environment variables above, because I'm able to do things like install plugins from the plugin manager, and use the proxy in various other build tasks. But consistently the slack plugin just times out when connecting to slack.com I'm very close to pivoting and leveraging curl to send my requests... I've tried this with slack plugin 2.2 and slack 2.3 |
|
Hey,it is not using any of the http_proxy env . you should configure the proxy information on Jenkins itself.Let me find out the navigation path for you when I get back to my computer.Jim Sent from my BlackBerry - the most secure mobile device - via the Bell Network From: notifications@git.luolix.topSent: October 19, 2017 6:05 PMTo: slack-plugin@noreply.git.luolix.topReply-to: reply@reply.git.luolix.topCc: jim@itmercenaries.ca; comment@noreply.git.luolix.topSubject: Re: [jenkinsci/slack-plugin] Rebase and resolve original PR #156 to fix issue #102 from nevermindr (#299) double posting from #148 to try and get a response from a party who is watching...
Can anyone please give me some insight here. I'm trying to use this plugin in my Jenkins Pipeline build behind a proxy in an enterprise environment.
slackSend isn't honoring http_proxy, https_proxy, or HTTP_PROXY, HTTPS_PROXY or -Dhttp.proxyHost or -Dhttps.proxyHost.
I know Jenkins use the proxy by leveraging one of the environment variables above, because I'm able to do things like install plugins from the plugin manager, and use the proxy in various other build tasks.
But consistently the slack plugin just times out when connecting to slack.com
I'm very close to pivoting and leveraging curl to send my requests... I've tried this with slack plugin 2.2 and slack 2.3
—You are receiving this because you commented.Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@caleyg Login to your jenkins instance, go to "Manage Jenkins", then click "Manage plugins", then click Tab: advanced, then fill your "HTTP Proxy Configuration". |
|
Thank you :)
…On Oct 19, 2017 5:44 PM, "Jiameng Yu" ***@***.***> wrote:
@caleyg <https://github.com/caleyg> Login to your jenkins instance, go to
"Manage Jenkins", then click "Manage plugins", then click Tab: advanced,
then fill your "HTTP Proxy Configuration".
Your SlackSend should be working as expected behind enterprise proxy.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#299 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEAIGTmZYgLVKh7xkzBdxMRsqa01dR4Iks5st9DBgaJpZM4MUa60>
.
|
Resolved the conflicts and tested the proxy issue.