replace eddsa dependency with eddsa-api plugin #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that sshd is not in core and a plugin this dependency seems to be incorrect here, however I am making the most minimal changes for plugins to use the eddsa-api and am not investing time in checking the hypothesis.
timja
approved these changes
May 20, 2024
|
needs Jenkins core bump 🤦 |
jtnord
commented
May 20, 2024
| <artifactId>bom-2.361.x</artifactId> | ||
| <version>2102.v854b_fec19c92</version> | ||
| <artifactId>bom-2.426.x</artifactId> | ||
| <version>2555.v3190a_8a_c60c6</version> |
There was a problem hiding this comment.
first release of the bom not the latest to reduce any uneeded bumps
|
|
there is a quite a few plugins on the list to update. |
|
ping @jenkinsci/sshd-plugin-developers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that sshd is not in core and a plugin this dependency seems to be incorrect here, however I am making the most minimal changes for plugins to use the eddsa-api and am not investing time in checking the hypothesis.
Testing done
Submitter checklist