Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSHD startup should *not* be asynchronous #20

Merged
merged 1 commit into from
Oct 10, 2017

Conversation

jglick
Copy link
Member

@jglick jglick commented Oct 5, 2017

Amends #19 as per comments there.

@reviewbybees @olivergondza

@ghost
Copy link

ghost commented Oct 5, 2017

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@olivergondza
Copy link
Member

@jglick, I was experiencing this with 1.6 so before the fix (I had no idea already existed). I have retested against 1.11 it has the desired effect. Thanks!

@oleg-nenashev oleg-nenashev self-requested a review October 9, 2017 15:37
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐝 , I'd guess. I have though the main objective is to speedup Jenkins startup time.

Will integrate and release this week

@oleg-nenashev oleg-nenashev self-assigned this Oct 9, 2017
@oleg-nenashev
Copy link
Member

@reviewbybees done

@olivergondza
Copy link
Member

@oleg-nenashev, I have not realized Jesse had already achieved that objective in more predictable way.

@olivergondza olivergondza merged commit 53200ee into jenkinsci:master Oct 10, 2017
@jglick jglick deleted the no-async-startup branch October 26, 2017 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants