Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming TheTest to UserPropertyImplTest for clarity #43

Merged
merged 1 commit into from
Mar 3, 2021

Conversation

jglick
Copy link
Member

@jglick jglick commented Mar 3, 2021

No description provided.

@jglick jglick added the tests label Mar 3, 2021
@@ -29,7 +29,6 @@ private void testRoundtrip(String publicKey) throws Exception {
foo.addProperty(new UserPropertyImpl(publicKey));
r.configRoundtrip(foo);
assertEquals(publicKey, foo.getProperty(UserPropertyImpl.class).authorizedKeys);
// integration testing w/ sshd-module is in hudson.cli.CLITest.strictHostKey in core
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obsolete after #38 now that

public void strictHostKey() throws Exception {
is here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(even after #44)

Copy link
Contributor

@kuisathaverat kuisathaverat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK?

@timja timja merged commit afd2a01 into jenkinsci:master Mar 3, 2021
@jglick jglick deleted the UserPropertyImplTest branch March 3, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants