Fast index view search #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The presence of index.html in a side file can be tested eagerly to avoid checking it at runtime. Since this feature is rarely used, this results in a performance gain. See: #97
Make IndexViewDispatcher a facet-local thing.
Move the logic that adds IndexViewDispatcher to Facet so that Facet subtypes can do this better.
Statically determine if index view page exists, and add a dispatcher only if so.
|
Tested with the tip of Jenkins to make sure all the tests pass |
|
@reviewbybees |
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of PR #101 to improve the request routing performance by resolving the available index view routes upfront.
That is, instead of looking for a presence of
index.jelly(and the likes) at the request processing time, this change makes that check happen duringMetaClassconstruction time.