Always reject the #getClass() method #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-beck
commented
Dec 11, 2018
| @@ -182,7 +182,7 @@ public String toString() { | |||
| }); | |||
| } | |||
|
|
|||
| FunctionList getMethods = node.methods.prefix("get"); | |||
| FunctionList getMethods = node.methods.prefix("get").filter(m -> !m.getSignature().equals("method getClass")); | |||
There was a problem hiding this comment.
method java.lang.Object getClass actually.
So it looks like this deserves a test after all.
Wadeck
approved these changes
Dec 11, 2018
daniel-beck
force-pushed
the
always-reject-getClass
branch
from
eed4027
to
dea099a
Compare
jglick
approved these changes
Dec 14, 2018
| Assert.assertFalse(metaClass.dispatchers.stream().filter(d -> d instanceof NameBasedDispatcher).anyMatch(d -> ((NameBasedDispatcher) d).name.equals("class"))); | ||
|
|
||
| // in fact, there should be no name based dispatchers at all | ||
| Assert.assertFalse(metaClass.dispatchers.stream().anyMatch(d -> d instanceof NameBasedDispatcher)); |
There was a problem hiding this comment.
Could just drop the first assertion in that case?
There was a problem hiding this comment.
The redundancy here captures the intent better IMO.
|
merge with |
Improved the code instead 🤓 |
Wadeck
approved these changes
Dec 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be no legitimate use case for allowing
#getClass()to be called, and not allowing it will make the following statement true:#153 (comment) has a more limited variant of that, and there's no reason it should not be true.
Untested.
@Wadeck