[JENKINS-39414] - Workaround Ruby Runtime Plugin and Jenkins 2.28 compatibility issues #85
Conversation
…on and Ruby classes
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
…Fields() when a Jenkins plugin uses obsolete Stapler lib
oleg-nenashev
changed the title
| return navigator.getDeclaredFields(clazz); | ||
| try { | ||
| return navigator.getDeclaredFields(clazz); | ||
| } catch (AbstractMethodError err) { |
There was a problem hiding this comment.
Actually this handling supresses error I've expected to catch in tests, but tests on aligned stapler module versions pass independently of this hack
|
Likely https://github.com/jenkinsci/jenkins.rb needs a similar fix |
| return navigator.getDeclaredFields(clazz); | ||
| } catch (AbstractMethodError err) { | ||
| // A plugin uses obsolete version of Stapler-dependent library (e.g. JRuby), which does not offer the method (JENKINS-39414) | ||
| // TODO: what to do with Logging? The error must be VERY visible, but it will totally pollute system logs |
There was a problem hiding this comment.
Both options do not work since we may invoke this method dozens and dozens of times during serving a single page. I would rather trigger administrative monitor in Jenkins, but it requires something (e.g. publicly accessible static field with a list of failed navigators). A bit hackish...
|
🐝 |
|
🐝 |
|
@reviewbybees done |
|
This pull request has completed our internal processes and we now respectfully request the maintainers of this repository to consider our proposal contained within this pull request for merging. |
|
🐝 Actually I think |
Yes, it's a common pitfall of Maven multi-module projects. Actually there are many repositories to be decoupled if we follow such approach. |
|
@kohsuke @jglick @rsandell @daniel-beck Ping. We need a release ASAP. |
|
I have merged, but only @kohsuke can release as it needs to be signed by his key iirc. |
Stapler 1.266 was formally compatible if we take a set of modules, but we didn't take into account that components like
stapler-jrubyare actually standalone libs being bundled in plugins like Ruby Runtime.Verifies there is no regression in the Jenkins core itself.
Error suppression is a weird approach, but I cannot offer anything better in the current state. A long-term fix would be to rework Stapler multi-module structure and to somehow ensure that entire stapler code gets delivered via something like core module
https://issues.jenkins-ci.org/browse/JENKINS-39414
@reviewbybees